feat(redis): Inject creds via volume#1112
Merged
openshift-merge-bot[bot] merged 6 commits intoredhat-developer:masterfrom Apr 28, 2026
Merged
feat(redis): Inject creds via volume#1112openshift-merge-bot[bot] merged 6 commits intoredhat-developer:masterfrom
openshift-merge-bot[bot] merged 6 commits intoredhat-developer:masterfrom
Conversation
Signed-off-by: Oliver Gondža <[email protected]>
Signed-off-by: Oliver Gondža <[email protected]>
olivergondza
changed the title
Signed-off-by: Oliver Gondža <[email protected]>
olivergondza
force-pushed
the
redis-creds-via-volume
branch
from
91ed74d to
57ed555
Compare
Collaborator
Author
|
Test failures are relevant... |
Signed-off-by: Oliver Gondža <[email protected]>
Signed-off-by: Oliver Gondža <[email protected]>
Collaborator
Author
|
/test v4.14-kuttl-sequential |
1 similar comment
Collaborator
Author
|
/test v4.14-kuttl-sequential |
Collaborator
Author
|
/retest |
Member
|
/lgtm /approve |
…into redis-creds-via-volume Signed-off-by: Oliver Gondža <[email protected]>
|
curious why code-rabbit did not pick this up |
Collaborator
Author
Imo we use it in argocd-operator only, not sure why |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anandf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
anandf
approved these changes
Apr 28, 2026
openshift-merge-bot
Bot
merged commit 02400d0
into
redhat-developer:master
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why we need it:
Avoid passing the password over environment variables and command line arguments. Downstream of:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
Blocked until the upstream PRs are merged.